Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in kubedns-controller.yaml.sed #42802

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Fix typo in kubedns-controller.yaml.sed #42802

merged 1 commit into from
Mar 14, 2017

Conversation

lukaszo
Copy link
Contributor

@lukaszo lukaszo commented Mar 9, 2017

cc @MrHohn

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@MrHohn
Copy link
Member

MrHohn commented Mar 9, 2017

/assign

@MrHohn
Copy link
Member

MrHohn commented Mar 9, 2017

Thanks for the fix!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 9, 2017
bowei
bowei approved these changes Mar 9, 2017
View reviewed changes
Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve /lgtm

@lukaszo
Copy link
Contributor Author

lukaszo commented Mar 9, 2017

@bowei can you also set a 1.6 milestone?

@saad-ali saad-ali added this to the v1.6 milestone Mar 9, 2017
@saad-ali saad-ali added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 9, 2017
@MrHohn
Copy link
Member

MrHohn commented Mar 14, 2017

/approve

@MrHohn
Copy link
Member

MrHohn commented Mar 14, 2017

@bowei This is missing approve label.

@MrHohn MrHohn mentioned this pull request Mar 14, 2017
Merged
@bowei
Copy link
Member

bowei commented Mar 14, 2017

/approve

@bowei
Copy link
Member

bowei commented Mar 14, 2017

/APPROVE

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: MrHohn, bowei, lukaszo

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@lukaszo
Copy link
Contributor Author

lukaszo commented Mar 14, 2017

@k8s-bot unit test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 14, 2017 •
edited

@lukaszo: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins kops AWS e2e dd408d2 link @k8s-bot kops aws e2e test this
Jenkins non-CRI GCE e2e dd408d2 link @k8s-bot non-cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot merged commit bebfdbb into kubernetes:master Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei approved these changes

Assignees

@bowei bowei

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lukaszo @k8s-reviewable @MrHohn @bowei @k8s-github-robot @k8s-ci-robot @saad-ali